Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stacked bar charts to progress report table #3224

Merged
merged 3 commits into from
Sep 18, 2018
Merged

Add stacked bar charts to progress report table #3224

merged 3 commits into from
Sep 18, 2018

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Sep 14, 2018 •
edited
Loading

pinging @normanrz for "ui review" and @daniel-wer for code review

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • checkout the progress report
    image

Issues:

@philippotto philippotto self-assigned this Sep 14, 2018
daniel-wer
daniel-wer approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot, code looks good!

@normanrz
Copy link
Member

Looks really good. Can you check with Heiko whether he approves the design?

@philippotto philippotto merged commit 7d9ba42 into master Sep 18, 2018
philippotto added a commit that referenced this pull request Sep 18, 2018
@philippotto
Revert "Add stacked bar charts to progress report table (#3224)"
0f51c3a 
This reverts commit 7d9ba42.
@philippotto philippotto mentioned this pull request Sep 18, 2018
Merged
philippotto added a commit that referenced this pull request Sep 18, 2018
@philippotto
Revert "Add stacked bar charts to progress report table (#3224)" (#3236)
4513fc6 
This reverts commit 7d9ba42.
philippotto added a commit that referenced this pull request Sep 18, 2018
@philippotto
Revert "Revert "Add stacked bar charts to progress report table (#3224)…
e0cea12 
…" (#3236)"

This reverts commit 4513fc6.
@philippotto philippotto deleted the progress-diagrams branch September 18, 2018 13:19
philippotto added a commit that referenced this pull request Sep 19, 2018
@philippotto
Add stacked bar charts to progress report table (#3237)
0d7bfce 
* Revert "Revert "Add stacked bar charts to progress report table (#3224)" (#3236)"

This reverts commit 4513fc6.

* make active projects orange, show progress percentages (100% will be highlighted in green), overall tweaking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

@normanrz normanrz Awaiting requested review from normanrz

Assignees

@philippotto philippotto

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visual progress bars in the Project Progress view
3 participants
@philippotto @normanrz @daniel-wer