Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brush size settings and shortcuts #3126

Merged
merged 7 commits into from
Aug 29, 2018

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Aug 28, 2018

This PR adds a second keyboard shortcut to volume tracing to increase/decrease the brush size. It also added it to the settings in the settings tab on the left side.

URL of deployed dev instance (used for testing):

Steps to test:

  • open volume tracing and select the brush mode
  • the brush should resize according to the settings set on the left tab, and according to the shortcuts (shift + mouse wheel/ shift + i,o)
  • the settings option for the brush size should only appear in volume tracing

Issues:


Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@@ -280,6 +285,15 @@ class UserSettingsView extends PureComponent<UserSettingsViewProps> {
const volumeTracing = enforceVolumeTracing(this.props.tracing);
panels.push(
<Panel header="Volume Options" key="3b">
<LogSliderSetting
label="Bursh Size"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo Brush Size

@MichaelBuessemeyer MichaelBuessemeyer merged commit bfaf55e into master Aug 29, 2018
@philippotto
Copy link
Member

Nice 👍 Can you comment here that you implemented this, @MichaelBuessemeyer? https://discuss.webknossos.org/t/brush-size-in-volume-mode/285/12

In the cases, where we know who exactly wished for a specific feature (i.e., when there is a discuss link in the gh issue), we usually let them directly know about it, since not everybody looks through the changelog regularly :)

@daniel-wer daniel-wer deleted the add-brush-size-settings-and-shortcuts branch September 3, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add brush size to settings and add brush size shortcuts
3 participants