Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure team administration when pausing/unpausing projects #3097

Merged
merged 3 commits into from
Aug 23, 2018
Merged

ensure team administration when pausing/unpausing projects #3097

merged 3 commits into from
Aug 23, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 23, 2018 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • login as a normal user, visit /projects (by typing it in the url bar) and try to pause/resume a project.
  • should get error toast

Issues:

  • Updated changelog
  • [ ] Updated migration guide if applicable
  • [ ] Needs datastore update after deployment
  • Ready for review

@fm3 fm3 self-assigned this Aug 23, 2018
@fm3 fm3 requested a review from rschwanhold August 23, 2018 11:31
rschwanhold
rschwanhold approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@rschwanhold rschwanhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fm3 fm3 merged commit 724dd85 into master Aug 23, 2018
@fm3 fm3 deleted the pause-project-privileged branch August 23, 2018 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschwanhold rschwanhold rschwanhold approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-privileged users can pause/resume projects
2 participants
@fm3 @rschwanhold