Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable focus on tabbar in tracing view when tabs are selected #3042

Merged
merged 5 commits into from
Aug 14, 2018
Merged

Disable focus on tabbar in tracing view when tabs are selected #3042

merged 5 commits into from
Aug 14, 2018

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Aug 13, 2018 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • go to the tracing view
  • change the tab
  • test the keyboard shortcuts; they should work without setting the focus back to the document

Issues:

@MichaelBuessemeyer MichaelBuessemeyer self-assigned this Aug 13, 2018
philippotto
philippotto approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👍

@MichaelBuessemeyer MichaelBuessemeyer merged commit 1fa58eb into master Aug 14, 2018
@normanrz normanrz deleted the disable-tabbar-focus branch February 20, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@MichaelBuessemeyer MichaelBuessemeyer

Labels
enhancement frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make tab-bar unfocused after changing tabs
2 participants
@MichaelBuessemeyer @philippotto