Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to explorative annotations view #3035

Merged
merged 6 commits into from
Aug 13, 2018

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Aug 12, 2018

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • go to the explorative annotations view in the dashboard
  • hover over the names of each explorative annotation
  • the descriptions should show up
  • if no description exists, there should be a default text

Issues:


Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 I made a suggestion to improve the UX a bit, since name and description is a bit intertwined now.

Maybe, also only show the popover when clicking the icon, and on hover show a tooltip saying "Show description". That way, it becomes even more clear what the button does. Since the column title reads "Name", we should be careful that the user still understands what is going on.

placement="topLeft"
>
<div>
<EditableTextLabel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! However, I find it a bit weird from a UX perspective, that the popover always shows when you hover over the edit button or the name input. I'd change the structure as follows:

<div>
  <EditableTextLabel ... />
  <Popover>
    <i className="fa fa-align-justify" />
  </Popover>
</div>

That way, the description is a separate thing.

CHANGELOG.md Outdated
@@ -13,6 +13,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.md).

- Added two new properties to mapping json files. The `colors: [<hsvHueValue1>, <hsvHueValue2>, ...]` property can be used to specify up to 256 custom colors for the first 256 equivalence classes of the mapping. The `hideUnmappedIds: <true|false>` property indicates whether segments that were not mapped should be rendered transparently or not. [#2965](https://github.com/scalableminds/webknossos/pull/2965)
- Added a button for refreshing the dataset in the backend cache. [#2975](https://github.com/scalableminds/webknossos/pull/2975)
- Added a popover to the explorative annotations view that displays when hovered over the name of an annotation. [#3035](https://github.com/scalableminds/webknossos/pull/3035)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, this is a bit too detailed. I'd change it to "Added the possibility to see the description of a tracing within the dashboard."

@MichaelBuessemeyer MichaelBuessemeyer changed the title add description to explorative annotations view Add description to explorative annotations view Aug 13, 2018
@MichaelBuessemeyer
Copy link
Contributor Author

@philippotto Please have a look at the newest changes that added the suggested tooltip.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good 👍

@MichaelBuessemeyer MichaelBuessemeyer merged commit a298f49 into master Aug 13, 2018
@normanrz normanrz deleted the add-discription-to-explorative-view branch February 20, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show description of tracing in explorative annotation view
2 participants