Check team and project name validity #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBuessemeyer
changed the title
philippotto
requested changes
Aug 13, 2018
| @@ -99,8 +99,14 @@ class ProjectCreateView extends React.PureComponent<Props, State> { | |||
| rules: [ | |||
| { | |||
| required: true, | |||
| pattern: "^[a-zA-Z0-9_-]*$", | |||
| message: "invalide project name, there are no whitespaces allowed", | |||
There was a problem hiding this comment.
Maybe "The project name must not contain whitespace." (with fullstop), since this is a user-facing message.
| { | ||
| min: 3, | ||
| required: true, | ||
| message: "project name must be at least 3 characters long", |
There was a problem hiding this comment.
"Project name [...] ." (capitalization and full stop)
| { | ||
| required: true, | ||
| pattern: "^[A-Za-z0-9\\-_\\. ß]+$", | ||
| message: "Please enter a valide team name.", |
| const newTeam = { | ||
| name: this.state.newTeamName, | ||
| name: values["Team Name"], |
There was a problem hiding this comment.
This syntax (having a string instead of a variable inside the square brackets) is usually a sign that something is weird :) In this case, you should rename "Team Name" to "teamName" in your getFieldDecorator call. Then, you can access `values.teamName" here.
CHANGELOG.md
Outdated
| @@ -23,7 +23,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.md). | |||
| - Added the possibility to copy volume tracings to own account | |||
| - During the import of multiple NML files, the user can select an option to automatically create a group per file so that the imported trees are organized in a hierarchy. [#2908](https://github.com/scalableminds/webknossos/pull/2908) | |||
| - Added functions to the front-end API to activate a tree and to change the color of a tree. [#2997](https://github.com/scalableminds/webknossos/pull/2997) | |||
| - When a new team is created invalid names will be directly marked in red [#2591](https://github.com/scalableminds/webknossos/issues/2591) | |||
| - When a new team or project is created invalid names will be directly marked in red. [#3034](https://github.com/scalableminds/webknossos/pull/3034) | |||
There was a problem hiding this comment.
I'd add a comma before "invalid names".
|
@philippotto Please review my changes again. |
philippotto
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: