Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compoundtracing permission lookup #3023

Merged
merged 2 commits into from
Aug 9, 2018
Merged

fix compoundtracing permission lookup #3023

merged 2 commits into from
Aug 9, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 9, 2018 •
edited
Loading

Compared String with Option[String] – Sadly, the compiler allows this…

URL of deployed dev instance (used for testing):

Steps to test:

  • create task, trace some, finish (one is enough)
  • view task from admin→tasks menu
  • url should feature “CompoundTask”, tracing should load

Issues:

@fm3 fm3 self-assigned this Aug 9, 2018
rschwanhold
rschwanhold approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@rschwanhold rschwanhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fm3 fm3 merged commit ea0856f into master Aug 9, 2018
@fm3 fm3 deleted the fix-compoundtracing-permissions branch August 9, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschwanhold rschwanhold rschwanhold approved these changes

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Viewing CompoundTask fails (validateUserAccess)
3 participants
@fm3 @philippotto @rschwanhold