Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show sticky toast if progress report request fails #2955

Merged
merged 4 commits into from
Jul 24, 2018
Merged

Show sticky toast if progress report request fails #2955

merged 4 commits into from
Jul 24, 2018

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jul 24, 2018 •
edited by fm3
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • lower RELOAD_INTERVAL in project_progress_report_view.js to 10 seconds or something
  • visit the project progress page and delete your auth cookie via dev tools
  • after 10 seconds, a sticky toast should show up

Issues:

@philippotto philippotto self-assigned this Jul 24, 2018
fm3
fm3 approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, I think that’s a real improvement!

@philippotto philippotto merged commit 207a2fb into master Jul 24, 2018
@fm3 fm3 deleted the sticky-toast-report branch July 26, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

@daniel-wer daniel-wer Awaiting requested review from daniel-wer

Assignees

@philippotto philippotto

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show sticky toast if progress report request fails
2 participants
@philippotto @fm3