Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the delete initial node warning in tasks #2812

Merged
merged 2 commits into from
Jun 27, 2018

Conversation

daniel-wer
Copy link
Member

Mailable description of changes:

  • Fixed an unnecessary warning when deleting a tree in a task, that warned about deleting the initial node although the initial node was not contained in the deleted tree.

URL of deployed dev instance (used for testing):

Steps to test:

  • Create a task. Open the task and create a second tree. Deleting the second tree should not trigger the "really delete the initial node" warning, but only the "really delete the tree" warning. Deleting the first tree should trigger the "really delete the initial node" warning.

Issues:


  • Ready for review

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@daniel-wer daniel-wer merged commit 65b31df into master Jun 27, 2018
@daniel-wer daniel-wer deleted the fix-delete-initial-node-warning branch June 27, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants