Fix renaming of trees with no name #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although trees with an empty name were renamed, they were not persisted. This PR fixes that by starting the respective tree-renaming saga later, so the save-saga is properly initialized beforehand.
Mailable description of changes:
URL of deployed dev instance (used for testing):
Steps to test:
Create some tasks. Open a task - the save button should show an hourglass.
Press save and leave the page.
Download the task on the dashboard, the nml should contain the correct tree name.
Same should be the case if the task is started using the "Finish and get next task" button.
Issues: