Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tackle high page-load (and api response) times #3418

Closed
fm3 opened this issue Oct 30, 2018 · 4 comments
Closed

Tackle high page-load (and api response) times #3418

fm3 opened this issue Oct 30, 2018 · 4 comments
Labels

Comments

@fm3
Copy link
Member

fm3 commented Oct 30, 2018

slowest requests (avg of last three days):

  32300 ms    /controllers.ReportController.projectProgressOverview
  29000 ms    /controllers.StatisticsController.webKnossos
   5380 ms    /controllers.DataSetController.list
   4560 ms    /controllers.WKDataStoreController.updateAll
   3970 ms    /controllers.StatisticsController.users
   3550 ms    /controllers.UserController.list
   3360 ms    /controllers.DataSetController.thumbnail
   3250 ms    /controllers.ReportController.openTasksOverview
   1750 ms    /controllers.TimeController.getWorkingHoursOfAllUsers
   1460 ms    /controllers.ProjectController.listWithStatus
   1100 ms    /controllers.ProjectController.list
    972 ms    /controllers.AnnotationController.duplicate
    785 ms    /controllers.AnnotationIOController.upload
    457 ms    /controllers.AnnotationIOController.download
    445 ms    /controllers.ProjectController.transferActiveTasks
    397 ms    /controllers.TaskController.createFromFiles
    383 ms    /controllers.TaskController.peekNext
    308 ms    /controllers.UserController.annotations
    280 ms    /controllers.Authentication.handleRegistration
    226 ms    /controllers.TaskController.request

ReportController and StatisticsController is ok to be slow (for now).
Thumbnail is slow because hundreds of those are called at the exact same time, when the frontend decides its cache is gone (maybe paginate the gallery to send less thumbnail requests?). Upload/Download depends on individual size of tracing, also ok for now, I’d say.
Can we optimize the list queries? (Maybe with some caching / compactWrites omitting unused fields?)

@philippotto
Copy link
Member

philippotto commented Dec 13, 2018

Btw, HTTP caching of the thumbnails seems to be missing completely. At least, chrome devtools never show "loaded from cache" for the thumbnails. We probably should set appropriate headers to nudge the browser to cache these.

  • Double check HTTP caching for thumbnails

@philippotto
Copy link
Member

Status from how I see it:

  • dataset route was optimized
  • thumbnail performance was improved by using better cache control

I'll move this back to backlog, @fm3. Feel free to close or re-manage.

@fm3
Copy link
Member Author

fm3 commented Feb 1, 2019

Fine by me. Of course, other things can always be optimized but I don’t think there’s any acute problem :)

@fm3
Copy link
Member Author

fm3 commented Jul 12, 2019

closing this since several of the slow calls have been optimized in the meantime :-) statistics and report pages are still slow, but this is expected and no one complained about that.

@fm3 fm3 closed this as completed Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants