Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize Hybrid tracings #3288

Closed
8 of 10 tasks
philippotto opened this issue Sep 27, 2018 · 4 comments
Closed
8 of 10 tasks

Finalize Hybrid tracings #3288

philippotto opened this issue Sep 27, 2018 · 4 comments
Assignees

Comments

@philippotto
Copy link
Member

philippotto commented Sep 27, 2018

When we have versioning for volume tracing, we should try to push hybrid tracings to being the new standard. This includes:

  • Backend
    • complete versioning for volume mode
    • allow "conversion" of skeleton/volume to hybrid (lazy initialize the missing part)
    • restrictions where appropriate (e.g., tasks)
  • Frontend
    • complete versioning for volume mode
    • allow "conversion" of skeleton/volume to hybrid (lazy initialize the missing part)
    • restrictions where appropriate (e.g., tasks)
  • mark hybrids as non-experimental
  • remove "create only skeleton/volume tracing" from UI or make it non-default (later)
@youri-k youri-k self-assigned this Oct 5, 2018
youri-k pushed a commit that referenced this issue Oct 5, 2018
fm3 pushed a commit that referenced this issue Oct 9, 2018
* create a make-hybrid route which lets you turn any non-hybrid tracing into a hybrid tracing #3288

* implement pr feedback #3324
@daniel-wer daniel-wer self-assigned this Oct 24, 2018
@philippotto
Copy link
Member Author

@youri-k The backend would also need to support skeleton/volume mode for tasks (types). It should probably be enough to have a some sort of tracing type flag for a task (type?). So, it's either "skeleton", "volume" or hybrid. In the UI, we would probably show this as two checkboxes (one for skeleton and one for volume) for which at least one has to be active.

@daniel-wer
Copy link
Member

daniel-wer commented Oct 24, 2018

@youri-k It looks like when making a skeleton tracing hybrid, the created volume tracing is created using the "use a new segmentation layer" option, which makes the segmentation, that was visible in the skeleton tracing before, disappear. I would think the "use existing segmentation layer" option is more appropriate in this case, what do you think?

Edit: You can try this out on the enable-hybrid-tracings branch, create a skeleton tracing and then press the "Convert to Hybrid" button in the info tab :)

@fm3
Copy link
Member

fm3 commented Oct 25, 2018

Note that tasks do not have volume mode yet because some things are not defined for volumes (like merging multiple ones). This might be slightly more complex than thought.

@daniel-wer
Copy link
Member

Followup in #3433.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants