Skip to content

Commit

Permalink
Use valid name as the default volume layer name (#6321)
Browse files Browse the repository at this point in the history
* Use valid name as the default volume layer name
* fix typo and update changelog
  • Loading branch information
daniel-wer authored Jul 7, 2022
1 parent fca7919 commit 27f31ac
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released

### Changed
- Merged the "Shared Annotations" tab into the "Annotations" tab in the user's dashboard. If annotations are shared with you, you can see them in your dashboard. The table can be filtered by owner if you prefer to see only your own annotations. [#6230](https://github.com/scalableminds/webknossos/pull/6230)
- Changed the name of the volume annotation layer in tasks to be "Volume" instead of "Volume Layer". [#6321](https://github.com/scalableminds/webknossos/pull/6321)

### Fixed
- Fixed that zooming out for datasets with very large scale was not possible until the coarsest level. [#6304](https://github.com/scalableminds/webknossos/pull/6304)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export function getReadableNameByVolumeTracingId(
tracingId: string,
) {
const volumeDescriptor = getVolumeDescriptorById(tracing, tracingId);
return volumeDescriptor.name || "Volume Layer";
return volumeDescriptor.name || "Volume";
}

export function getAllReadableLayerNames(dataset: APIDataset, tracing: Tracing) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ export function getLayerInfos(
// Satisfy flow.
throw new Error("Tracing is null, but layer.tracingId is defined.");
}
const readbleVolumeLayerName = getReadableNameOfVolumeLayer(layer, tracing) || "Volume Layer";
const readableVolumeLayerName = getReadableNameOfVolumeLayer(layer, tracing) || "Volume";
const volumeTracing = getVolumeTracingById(tracing, layer.tracingId);

if (layer.fallbackLayerInfo != null) {
return {
displayName: readbleVolumeLayerName,
displayName: readableVolumeLayerName,
layerName: layer.fallbackLayerInfo.name,
tracingId: volumeTracing.tracingId,
annotationId,
Expand All @@ -93,7 +93,7 @@ export function getLayerInfos(
}

return {
displayName: readbleVolumeLayerName,
displayName: readableVolumeLayerName,
layerName: null,
tracingId: volumeTracing.tracingId,
annotationId,
Expand Down

0 comments on commit 27f31ac

Please sign in to comment.