Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install "all extras" for Python 3.12 #1219

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix install "all extras" for Python 3.12 #1219

merged 2 commits into from
Nov 22, 2024

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Nov 22, 2024

Description:

  • This PR fixes the installation for pip install webknossos[all] for Python 3.12
  • The main issue is that the "extras" group all includes the extra czi which in turn installs pylibCZIrw.
    • pylibCZIrw is only available for Python <= 3.11. There is an open issue to support Py 3.12.
    • alternatively, users can manually install pip install --extra-index-url https://pypi.scm.io/simple/ webknossos[czi] which works with Python 3.12 and MacOS
    • Update README and documentation to match
    • Unrelated: restored "classifiers" on PyPI page and consequently should fix the little icon badge in the README.

Test

  • in a clean Python 3.12 environment run:
cd webknossos
uv build
pip install dist/webknosssos*.wheel

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Updated Documentation
  • Added / Updated Tests
  • Considered adding this to the Examples

@hotzenklotz hotzenklotz self-assigned this Nov 22, 2024
@@ -23,6 +23,10 @@ classifiers = [
"Topic :: Scientific/Engineering :: Visualization",
"Topic :: Software Development :: Libraries",
"Typing :: Typed",
"Programming Language :: Python :: 3.9",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes
Screenshot 2024-11-22 at 13 38 52

Screenshot 2024-11-22 at 13 40 59

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, shields.io can somehow parse the requires_python argument from the pyprpoject.toml and display a range instead of each version. However, that would not add this info to Pypi.org website where I typicall find it easier to spot at the first glance.

Code: https://img.shields.io/badge/dynamic/json?query=info.requires_python&label=python&url=https%3A%2F%2Fpypi.org%2Fpypi%2Fwebknossos%2Fjson

@hotzenklotz hotzenklotz marked this pull request as ready for review November 22, 2024 12:43
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 thanks for fixing this!

@hotzenklotz hotzenklotz enabled auto-merge (squash) November 22, 2024 12:56
@hotzenklotz hotzenklotz merged commit f5076eb into master Nov 22, 2024
19 checks passed
@hotzenklotz hotzenklotz deleted the czi branch November 22, 2024 13:05
@hotzenklotz
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants