Add toolkit-test #14
Merged
Add toolkit-test #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
reviewed
Apr 26, 2023
|
@adpi2 done! |
bishabosha
approved these changes
Apr 26, 2023
adpi2
reviewed
Apr 26, 2023
.github/workflows/deploy.yaml
Outdated
Comment on lines
68
to
72
| env: | ||
| OSSRH_USERNAME: ${{ secrets.OSSRH_USERNAME }} | ||
| OSSRH_PASSWORD: ${{ secrets.OSSRH_PASSWORD }} | ||
| PGP_PASSWORD: ${{ secrets.PGP_PASSPHRASE }} | ||
| PGP_KEY_ID: ${{ steps.import_gpg.outputs.fingerprint }} |
There was a problem hiding this comment.
Should we move those envs to the job level, to avoid repeating them so many times?
There was a problem hiding this comment.
Good idea! I moved all but the PGP_KEY_ID, because this one comes from a previous step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.