Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message class for missing type parameter in type application #7971

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Message class for missing type parameter in type application #7971

merged 1 commit into from
Jan 14, 2020

Conversation

jvdp
Copy link
Contributor

@jvdp jvdp commented Jan 12, 2020

As described in #1589

dottybot
dottybot reviewed Jan 12, 2020
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

liufengyun
liufengyun approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot @jvdp 🎉

@liufengyun liufengyun merged commit 4a51412 into scala:master Jan 14, 2020
@jvdp jvdp deleted the 1589-checking branch January 14, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@liufengyun liufengyun liufengyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvdp @liufengyun @dottybot