Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 'unknown named enclosing class or object' error to new scheme #7457

Merged

Conversation

x3ro
Copy link
Contributor

@x3ro x3ro commented Oct 27, 2019

Part of the effort documented in #1589 to port all error messages to
the new scheme.

This is my first dotty PR 🎉 Feedback very welcome!

Part of the effort documented in scala#1589 to port all error messages to
the new scheme.
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@x3ro x3ro mentioned this pull request Oct 27, 2019
em"""no enclosing class or object is named '${hl(name.show)}'"""
val explanation: String =
ex"""
|The class or object named '${hl(name.show)}' was used a visibility
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used as a visibility modifier

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks!

@OlivierBlanvillain
Copy link
Contributor

LGTM, thanks!

@OlivierBlanvillain OlivierBlanvillain merged commit 169e1db into scala:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants