Add error message when trait parameter prefixes are used for its parent #7393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Oct 8, 2019
kubukoz
reviewed
Oct 10, 2019
compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala
Outdated
Show resolved
Hide resolved
harpresing
force-pushed
the
master
branch
2 times, most recently
from
16766af to
9e22e85
Compare
| @@ -116,7 +116,7 @@ object RefChecks { | |||
| case TypeRef(ref: TermRef, _) => | |||
| val paramRefs = ref.namedPartsWith(ntp => ntp.symbol.enclosingClass == cls) | |||
| if (paramRefs.nonEmpty) | |||
| ctx.error("trait parameters cannot be used as parent prefixes", parent.sourcePos) | |||
| ctx.error(TraitParameterUsedAsParentPrefix(paramRefs.tail.head), parent.sourcePos) | |||
There was a problem hiding this comment.
What happens here if paramRefs has only one element? What is in paramRefs.head?
There was a problem hiding this comment.
paramRefs.head contains the enclosing class/trait and the second element in paramRefs is the trait which has the reference error. Given the nature of the error, paramRefs should always have 2 elements if it's nonEmpty.
Nonetheless, paramRefs.tail.head.symbol is the same as the parameter cls, so it's probably safer to use that instead. I'll make that change!
nicolasstucki
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackling lampepfl#1589. More specifically, added an explanation for the compiler error when a trait with parameters is extended from a parent that is accessed via any of the parameters of the same trait.
For example: