Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5546: Disallow comparing opaque types under -language:strictEqua… #5624

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Fix #5546: Disallow comparing opaque types under -language:strictEqua… #5624

merged 2 commits into from
Dec 17, 2018

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 16, 2018

…lity

Disallow comparing different opaque types under -language:strictEquality

@odersky
Fix scala#5546: Disallow comparing opaque types under -language:stric…
d48786c 
…tEquality

Disallow comparing different opaque types under -language:strictEquality
allanrenucci
allanrenucci approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we still compare an opaque type with its underlying type when we are in the opaque type companion object? I think it is worth adding it to the test

Otherwise LGTM

@odersky odersky merged commit 04c7aa1 into scala:master Dec 17, 2018
@allanrenucci allanrenucci deleted the fix-#5546 branch December 17, 2018 14:59
@Blaisorblade Blaisorblade mentioned this pull request Jan 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrenucci allanrenucci allanrenucci approved these changes

@OlivierBlanvillain OlivierBlanvillain Awaiting requested review from OlivierBlanvillain

Assignees

@OlivierBlanvillain OlivierBlanvillain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @allanrenucci @OlivierBlanvillain