Fix #5257: Support auto generic-tupling of parameters #5259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#5257
branch
from
e989b9a to
b0f0926
Compare
nicolasstucki
force-pushed
the
fix-#5257
branch
from
b0f0926 to
3740419
Compare
|
Rebased and added regression test |
nicolasstucki
force-pushed
the
fix-#5257
branch
from
de87f50 to
44aab3c
Compare
|
Rebased |
OlivierBlanvillain
approved these changes
Nov 1, 2018
| @@ -23,6 +23,7 @@ i4947b | |||
| i5119 | |||
| i5119b | |||
| i5188a | |||
| i5257.scala | |||
There was a problem hiding this comment.
Do you know what's failing?
There was a problem hiding this comment.
If I remember correctly there was a match type that was not explicitly expanded in some part of the tree.
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 4, 2021
…patmat This commit refactor the PR scala#5259 so that it will not impact pattern matching code. Pattern matching code requires members `_N` for patternMatcher phase to generate correct code. scala#5259
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 4, 2021
…patmat This commit refactor the PR scala#5259 so that it will not impact pattern matching code. The phase patternMatcher requires members `_N` for to generate correct code. scala#5259
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 6, 2021
…patmat This commit refactor the PR scala#5259 so that it will not impact pattern matching code. The phase patternMatcher requires members `_N` for to generate correct code. scala#5259
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 6, 2021
…patmat This commit refactor the PR scala#5259 so that it will not impact pattern matching code. The phase patternMatcher requires members `_N` for to generate correct code. scala#5259
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 11, 2021
This commit refactor the PR scala#5259 so that it will not impact pattern matching code. scala#5259 - tests/pos/automatic-tupling-of-function-parameters.scala This test requires dealiasing. - tests/run/function-arity.scala This test requires widen ExprType.
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 11, 2021
This commit refactor the PR scala#5259 so that it will not impact pattern matching code. scala#5259 - tests/pos/automatic-tupling-of-function-parameters.scala This test requires dealiasing. - tests/run/function-arity.scala This test requires widen ExprType.
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 15, 2021
This commit refactor the PR scala#5259 so that it will not impact pattern matching code. scala#5259 - tests/pos/automatic-tupling-of-function-parameters.scala This test requires dealiasing. - tests/run/function-arity.scala This test requires widen ExprType.
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 18, 2021
This commit refactor the PR scala#5259 so that it will not impact pattern matching code. scala#5259 - tests/pos/automatic-tupling-of-function-parameters.scala This test requires dealiasing. - tests/run/function-arity.scala This test requires widen ExprType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions:
*:as an auto-tupleable type for function parameters*:tuples usingapply(N)method instead of_Ns