Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]: Replace deprecated actions/create-release and actions/upload-release-assert actions #22176

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

WojciechMazur
Copy link
Contributor

@WojciechMazur WojciechMazur commented Dec 9, 2024

Both of these actions were archived in 2021. In the future they're going to fail, due to deprecation of set-output command in GitHub actions.
We replace their usage with a single gh release create command. It also allows us to simplify the workflow

[skip ci]

…se-asset` with `gh release create` command
@WojciechMazur
Copy link
Contributor Author

We can potentially consider explicitly listing files to upload without using glob selectors, but it seems unnecessary:

          scala3-${{ env.RELEASE_TAG }}.zip \
          scala3-${{ env.RELEASE_TAG }}.zip.sha256 \
          scala3-${{ env.RELEASE_TAG }}.tar.gz.sha256 \
          scala3-${{ env.RELEASE_TAG }}-x86_64-pc-linux.zip \
          scala3-${{ env.RELEASE_TAG }}-x86_64-pc-linux.zip.sha256 \
          scala3-${{ env.RELEASE_TAG }}-x86_64-pc-linux.tar.gz \
          scala3-${{ env.RELEASE_TAG }}-x86_64-pc-linux.tar.gz.sha256 \
          scala3-${{ env.RELEASE_TAG }}-aarch64-pc-linux.zip \
          scala3-${{ env.RELEASE_TAG }}-aarch64-pc-linux.zip.sha256 \
          scala3-${{ env.RELEASE_TAG }}-aarch64-pc-linux.tar.gz \
          scala3-${{ env.RELEASE_TAG }}-aarch64-pc-linux.tar.gz.sha256 \
          scala3-${{ env.RELEASE_TAG }}-x86_64-apple-darwin.zip \
          scala3-${{ env.RELEASE_TAG }}-x86_64-apple-darwin.zip.sha256 \
          scala3-${{ env.RELEASE_TAG }}-x86_64-apple-darwin.tar.gz \
          scala3-${{ env.RELEASE_TAG }}-x86_64-apple-darwin.tar.gz.sha256 \
          scala3-${{ env.RELEASE_TAG }}-aarch64-apple-darwin.zip \
          scala3-${{ env.RELEASE_TAG }}-aarch64-apple-darwin.zip.sha256 \
          scala3-${{ env.RELEASE_TAG }}-aarch64-apple-darwin.tar.gz \
          scala3-${{ env.RELEASE_TAG }}-aarch64-apple-darwin.tar.gz.sha256 \
          scala3-${{ env.RELEASE_TAG }}-x86_64-pc-win32.zip \
          scala3-${{ env.RELEASE_TAG }}-x86_64-pc-win32.zip.sha256 \
          scala3-${{ env.RELEASE_TAG }}-x86_64-pc-win32.tar.gz \
          scala3-${{ env.RELEASE_TAG }}-x86_64-pc-win32.tar.gz.sha256 \
          scala3-${{ env.RELEASE_TAG }}.msi \
          scala3-${{ env.RELEASE_TAG }}.msi.sha256

@WojciechMazur
Copy link
Contributor Author

The new approach was tested during 3.6.3-RC1 release: https://github.com/scala/scala3/actions/runs/12258476158/job/34204889698#step:15:1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants