Treat more closure parameter types as inferred #21583
Merged
+37
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for types that contain possibly illegal @retains annotations since those annotations are only removed before pickling for InferredTypes. Fixes scala#21347
The operations of an ExplainingTypeComparer are expensive. So we should only run it when producing an error message.
dwijnand
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Ah ok, didn't think it would be expensive, but I can understand that concern. My usecase is tracing execution, so running things twice is confusing and duplicative. So I might've used comparing { cmp => so I can switch back to the expensive TypeComparer.explaining { cmp => when debugging and avoid the double run. But my preference shouldn't impede your fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for types that contain possibly illegal @retains annotations since those annotations are only removed before pickling for InferredTypes.
Fixes #21437