Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds special treatment to Predef.classOf #21523

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

EnzeXing
Copy link
Contributor

This is an updated PR of #20945, making the global initialization checker skips the analysis of Predef.classOf in scala2-library, since it is a stub method in tasty and is replaced by actual class representations in the backend. This prevents related warnings when running test_scala2_library_tasty.

@EnzeXing EnzeXing changed the title adds special treatment to Predef.classOf Adds special treatment to Predef.classOf Aug 31, 2024
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @EnzeXing !

compiler/src/dotty/tools/dotc/transform/init/Objects.scala Outdated Show resolved Hide resolved
Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After you remove the debug code, this LGTM.

@olhotak olhotak merged commit 8527a9b into scala:main Sep 1, 2024
28 checks passed
@olhotak olhotak deleted the special-classof branch September 1, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants