Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable betterMatchTypeExtractors in >= 3.6 #21198

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Enable betterMatchTypeExtractors in >= 3.6 #21198

merged 1 commit into from
Aug 20, 2024

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Jul 15, 2024

Closes #20538.

@mbovel mbovel requested a review from smarter July 15, 2024 16:29
@smarter
Copy link
Member

smarter commented Jul 15, 2024

baseVersion is already 3.6.0 so I think we can just make the feature non-experimental now

hamzaremmal
hamzaremmal requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@hamzaremmal hamzaremmal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be deprecated in 3.6.0.

scala3/library/src/scala/runtime/stdLibPatches/language.scala

Line 127 in a212ff0

object betterMatchTypeExtractors

See example:

scala3/library/src/scala/runtime/stdLibPatches/language.scala

Line 70 in a212ff0

@deprecated("`clauseInterleaving` is now standard, no language import is needed", since = "3.6")

@smarter smarter changed the title Add regression tests for 20538 Enable betterMatchTypeExtractors in >= 3.6 Jul 16, 2024
@Gedochao Gedochao added the needs-minor-release This PR cannot be merged until the next minor release label Aug 5, 2024
@mbovel
Copy link
Member Author

mbovel commented Aug 5, 2024

This should also be deprecated in 3.6.0.

Done ✅

@mbovel mbovel force-pushed the mb/20538 branch 2 times, most recently from c1033c1 to 78fe701 Compare August 6, 2024 14:27
@mbovel mbovel requested a review from hamzaremmal August 7, 2024 08:29
@hamzaremmal hamzaremmal enabled auto-merge August 20, 2024 13:00
@hamzaremmal hamzaremmal merged commit 355910d into scala:main Aug 20, 2024
26 checks passed
@mbovel
Copy link
Member Author

mbovel commented Aug 20, 2024

Wait, should it really be merged now? I thought we should wait for a minor release.

@hamzaremmal
Copy link
Member

We are on a minor release cycle, we are currently working on 3.6.0

@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 8, 2024
@mbovel mbovel deleted the mb/20538 branch December 15, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

@hamzaremmal hamzaremmal hamzaremmal approved these changes

Assignees

@mbovel mbovel

@hamzaremmal hamzaremmal

Labels
needs-minor-release This PR cannot be merged until the next minor release
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Regression 3.4.0+: scenario where Tuple.InverseMap does not compute the expected type
5 participants
@mbovel @smarter @hamzaremmal @Gedochao @WojciechMazur