Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand classpath of pathing jars in scala_legacy command #21160

Merged
merged 1 commit into from
Jul 10, 2024
Merged

expand classpath of pathing jars in scala_legacy command #21160

merged 1 commit into from
Jul 10, 2024

Conversation

bishabosha
Copy link
Member

I think it still be best to delete the command, but we should ensure it works if we're going to ship it

this should have been part of #21121

@bishabosha bishabosha added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jul 10, 2024
@hamzaremmal
Copy link
Member

hamzaremmal commented Jul 10, 2024 •
edited
Loading

think it still be best to delete the command,

I agree but it was a collective decision by Scala Core.

@hamzaremmal hamzaremmal enabled auto-merge July 10, 2024 20:26
@hamzaremmal hamzaremmal merged commit 466676c into scala:main Jul 10, 2024
23 checks passed
@hamzaremmal hamzaremmal deleted the fix-classpath-scala_legacy branch July 10, 2024 21:26
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Jul 10, 2024
@WojciechMazur WojciechMazur added this to the 3.5.0 milestone Jul 10, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 10, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 11, 2024
@WojciechMazur
Backport "expand classpath of pathing jars in scala_legacy command " …
32fd2ba 
…to 3.5.0 (#21173)

Backports #21160 to 3.5.0-RC4 as followup to #21172
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" backport:done This PR was successfully backported. labels Jul 11, 2024
@WojciechMazur WojciechMazur modified the milestones: 3.5.0, 3.5.1 Jul 12, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 12, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 14, 2024
@WojciechMazur
Backport "expand classpath of pathing jars in scala_legacy command" t…
d251345 
…o 3.5.1 (#21184)

Backports #21160 to 3.5.1-RC1 as a follow up to #21183
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzaremmal hamzaremmal hamzaremmal approved these changes

@Gedochao Gedochao Awaiting requested review from Gedochao

@WojciechMazur WojciechMazur Awaiting requested review from WojciechMazur

Assignees

@hamzaremmal hamzaremmal

Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bishabosha @hamzaremmal @WojciechMazur