Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Unify completion pos usage, fix presentation compiler crash in interpolation" to LTS #20964

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Backport "Unify completion pos usage, fix presentation compiler crash in interpolation" to LTS #20964

merged 1 commit into from
Jul 3, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #19614 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

@rochala @WojciechMazur
Unify completion pos usage, fix presentation compiler crash in interp…
507f14a 
…olation (#19614)

Fixes crash for added tests in `CompletionInterpolatorSuite` along with
unification and better naming for completion pos, source pos, and span
usage.
[Cherry-picked 6b52789]
Base automatically changed from lts-19800 to lts-3.3 July 3, 2024 08:32
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-19921.

Reference

@WojciechMazur WojciechMazur merged commit a4e3a85 into lts-3.3 Jul 3, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the lts-19614 branch July 3, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WojciechMazur @rochala