-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing CompletionScalaCliSuite
tests due to circe releasing Scala Native 0.5 artifacts
#20931
Fix failing CompletionScalaCliSuite
tests due to circe releasing Scala Native 0.5 artifacts
#20931
Conversation
…a Native 0.5 artifacts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should find a better way to handle this kind of completions.
@tgodzik Coursier is quite big dependency and we only use it for this purpose. Maybe we could change the interface in a way that allows us to provide a handler for this kind of completions, and move away logic form the presentation compiler ?
Agree. It's just a fast fix although it seems that presentation compiler is not tested in the CI (I think so), but it started to fail locally. In such case if it's not blocking CI we can take time to make a better solution |
Surprisingly the CI failed in all of the modified tests. We would need to check why it behaves differently locally and in the CI |
That is highly surprising, this is basically cs complete-dep and its' output seems to work
We could add that to SymbolSearch interface, it would probably make sense and just mock it, test it inside metals |
If needed you can ignore the tests for now. |
…4 and 0.5 SN versins - the outputs seems be non deterministic in the CI
Blocking #20837 |
The recent release of circe for SN 0.5 changed the outputs of CompletionScalaCli suite. The PR fixes failing tests