-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Set baseVersion to 3.5.1-RC1" #20402
Conversation
I believe Mima filters need to be updated for the new base version. |
Yes, but 3.5.0-RC1 is not yet in Maven Central. I've reverted the PR as a hot fix and remerge it with the new base version when 3.5.0-RC1 is in Maven Central |
This is a matter of MiMa's known bug/weird behavior: It treats I don't get what it has to do with |
If 3.5.0-RC1 is available, we can do the following change to satisfy MiMA. |
MiMA checks is not a requirement that we enforce for a PR for now. I've asked @Gedochao to add this to tomorrow's core meeting agenda to have a final decision on adding it as a requirement. #20392 is a good argument to make it a requirement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was convicned that it is currently the best solution.
Now that 3.5.0-RC1 is in Maven Central, we can apply the correct fix #20404 |
This depends on 3.5.0-RC1 being released to Maven Central Part of #20402
@hamzaremmal now can we unrevert this? |
Reverts #20392
Closes #20401