Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend whitelist in global initialization checker #20290

Merged
merged 2 commits into from
May 1, 2024

Conversation

EnzeXing
Copy link
Contributor

This PR extends the whitelist in global object initialization checker in order to suppress initialization irrelevance errors in Scala2LibraryTasty.

@EnzeXing EnzeXing changed the title Extend whitelist and add tests Extend whitelist in global initialization checker Apr 29, 2024
Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun would you also like to have a look?

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @EnzeXing !

@olhotak olhotak merged commit 492f881 into scala:main May 1, 2024
19 checks passed
@olhotak olhotak deleted the extend-whitelist branch May 1, 2024 18:14
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants