Normalize for underlyingClassRef #20259
Conversation
Related to scala#20258 Here too, I would be fine with not normalizing, but in that case pos/i15827 should become a neg test.
| @@ -1584,7 +1584,8 @@ object Types extends TypeUtils { | |||
| else if (tp.symbol.isAliasType) tp.underlying.underlyingClassRef(refinementOK) | |||
| else NoType | |||
| case tp: AppliedType => | |||
| if (tp.tycon.isLambdaSub) NoType | |||
| if tp.isMatchAlias then tp.tryNormalize.underlyingClassRef(refinementOK) | |||
There was a problem hiding this comment.
For this and 20258, what if it's a match alias that doesn't normalise, don't you want to cascade to the later cases?
We don't really have an efficient way to do that (&& tp.tryNormalize.exists :-/)
There was a problem hiding this comment.
It might be incorrect but I had intentionally not cascaded to the later cases here. I don't think any of them would return something other than NoType on an unreducible match type.
There was a problem hiding this comment.
I think this goes against the spec. There is nothing in the spec supporting reducing match types when determining whether a type is a class type or not. And underlyingClassRef is exactly the implementation of "is it a class type", AFAICT.
So yes, pos/i15827.scala should probably be a neg test.
Related to #20258
Here too, I would be fine with not normalizing,
but in that case pos/i15827 should become a neg test.