Add -W enabling warnings #19843
Draft
Add -W enabling warnings #19843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymon-rd
force-pushed
the
add-w-enable-lint
branch
3 times, most recently
from
3b400b5 to
5e5e390
Compare
szymon-rd
force-pushed
the
add-w-enable-lint
branch
from
5e5e390 to
45e5c50
Compare
|
fyi @som-snytt |
|
So #18559, which this PR intends to implement, was assigned to me in this release cycle. So just wanted to check what is the status of this PR? Is it blocked? |
Linyxus
reviewed
Apr 22, 2024
| @@ -105,15 +110,22 @@ object Settings: | |||
| def isMultivalue: Boolean = summon[ClassTag[T]] == ListTag | |||
|
|
|||
| def acceptsNoArg: Boolean = summon[ClassTag[T]] == BooleanTag || summon[ClassTag[T]] == OptionTag || choices.exists(_.contains("")) | |||
|
|
|||
| s"\n- $name${if description.isEmpty() then "" else s" :\n\t${description.replace("\n","\n\t")}"}" | |||
There was a problem hiding this comment.
this seems to be an unused string value
|
@Linyxus not blocked, just needs to be finished and merged. I probably won't be able to do that in upcoming 2 weeks, but afterwards I may sit down to it I think. If you want to finish it, go ahead. Just keep in mind that sole -W was previously printing the help, so we may want to keep that behaviour - -X, -Y, etc do the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -W