Enable experimental on language imports #19760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
enable-experimental-on-language-imports
branch
2 times, most recently
from
6f93f72 to
14dae56
Compare
The `@experimental` flag is added to definitions in the scope where the the experimental language feature is imported.
nicolasstucki
force-pushed
the
enable-experimental-on-language-imports
branch
from
5d1624b to
2a1a72c
Compare
nicolasstucki
added
the
needs-minor-release
nicolasstucki
force-pushed
the
enable-experimental-on-language-imports
branch
2 times, most recently
from
01089a1 to
21407ce
Compare
nicolasstucki
force-pushed
the
enable-experimental-on-language-imports
branch
from
21407ce to
d35ec2a
Compare
This was referenced Feb 28, 2024
nicolasstucki
added a commit
that referenced
this pull request
Feb 29, 2024
Add explicitly `-experimental -Yno-experimental` to tests that use definitions that are `@experimental` in the standard library. `-Yno-experimental` disables the experimental mode from nightly builds and `-experimental` adds `@experimental` to all top-level definitions. This is in preparation of #19760 and the disabling of experimental mode by default in nightly builds. When nighly experimental mode will be disabled we will be able to drop the `-Yno-experimental`. These tests are for * `scala.annotation.MacroAnnotation` * `scala.annotation.MainAnnotation` * `scala.annotation.newMain` * `scala.util.TupledFunction` * Expreminetal definitions in `scala.quoted.Quotes`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier to use experimental language features out of the box. We already have
-experimentalthat enables experimental mode globally by adding the@experimentalannotation to all top-level definitions. The complication was that this flag was necessary to use experimental language features. It was not always easy to set (for example in the REPL) and it is all or nothing. Users can also annotate explicitly all top-level definitions that use language features with@experimental.Now, the import of an experimental language feature will automatically enable experimental mode. If the import is at the top-level, all definitions in the file are experimental. If the import is local only the top-level definition containing the import will be marked as experimental.
Some experimental features might not need the experimental mode.