Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid pure expression warning with Scala 2 library TASTy #18876

Conversation

nicolasstucki
Copy link
Contributor

The extra information on trait initialization causes an extra warning. The warning/errors in the check files should be the same. The test now do not desugar the erroneous code into a statement anymore to avoid this warning.

The extra information on trait initialization causes an extra warning.
The warning/errors in the check files should be the same. The test now
do not desugar the erroneous code into a statement anymore to avoid this
warning.
@nicolasstucki
Copy link
Contributor Author

This will be testable on the CI once we have #18875

@nicolasstucki nicolasstucki self-assigned this Nov 7, 2023
@nicolasstucki nicolasstucki marked this pull request as ready for review November 8, 2023 07:06
@nicolasstucki nicolasstucki requested a review from sjrd November 8, 2023 07:07
@nicolasstucki nicolasstucki assigned sjrd and unassigned nicolasstucki Nov 8, 2023
@nicolasstucki nicolasstucki merged commit 905e4bc into scala:main Nov 8, 2023
18 checks passed
@nicolasstucki nicolasstucki deleted the adapt-tests-to-avoid-pure-expression-warinig-with-scala2-library-tasty branch November 8, 2023 16:15
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants