More additions to the standard library #18799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
added
the
cc-experiment
odersky
force-pushed
the
more-stdlib
branch
2 times, most recently
from
45c7724 to
f6cd5c0
Compare
The logic gets refused by the added capture refinements.
Also count abstract types that have a @Sealed annotation on their bound as sealed. That way, we get free propagation into synthesized type parameters. We should probably unify this scheme and `sealed` modifiers.
This needs to be refined further for class members, similar to how we check that private types cannot escape from a class API.
The tricky thing here is how to recognize that a class is pure since that is known only during capture checking and we are at Setup, the phase before. But we can approximate by treating the `Pure` trait as definitely pure.
(capture checks out of the box)
No need for a separate entry in the context's store; we can keep everything in the phase itself, which is more efficient and modular.
Mutable variables can appeal to parametricty only if they are not captured. We use "not captured by any closure" as a sound approximation for that, since variables themselves are currently not tracked, so we cannot use soemthing more finegrained.
|
@Linyxus Cursory review is fine. Just to get an idea what's in the PR. |
Linyxus
approved these changes
Nov 5, 2023
|
This is the first version of collections in the standard library that is compiled with capture checking on. We'll use that as a baseline for a comprehensive test case when we refine the capture checking scheme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and fixes to make that happen.