Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #18282: consider Predef.eq/ne in nullability flow typing #18299

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix #18282: consider Predef.eq/ne in nullability flow typing #18299

merged 1 commit into from
Jul 28, 2023

Conversation

olhotak
Copy link
Contributor

@olhotak olhotak commented Jul 26, 2023 •
edited
Loading

Fixes #18282

@olhotak olhotak requested review from odersky and noti0na1 July 26, 2023 21:20
@olhotak olhotak self-assigned this Jul 26, 2023
noti0na1
noti0na1 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@noti0na1 noti0na1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit b9b1314 into scala:main Jul 28, 2023
@odersky odersky deleted the fix-flowtyping-predef branch July 28, 2023 16:06
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noti0na1 noti0na1 noti0na1 approved these changes

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

@olhotak olhotak

Labels
area:nullability
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

nullability flow typing ignores Predef.eq/ne
4 participants
@olhotak @odersky @noti0na1 @Kordyjan