Test stdlib-bootstrapped TASTy-MiMa in CI #18158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
test-TASTy-MiMa-in-CI
branch
5 times, most recently
from
a4e10dc to
fea4f47
Compare
|
In time we need to find better ways to make tools work with new versions of TASTy that are still experimental. |
nicolasstucki
commented
Jul 7, 2023
| @@ -255,6 +255,11 @@ jobs: | |||
| run: | | |||
| ./project/scripts/sbt ";scala3-interfaces/mimaReportBinaryIssues ;scala3-library-bootstrapped/mimaReportBinaryIssues ;scala3-library-bootstrappedJS/mimaReportBinaryIssues; tasty-core-bootstrapped/mimaReportBinaryIssues; stdlib-bootstrapped/mimaReportBinaryIssues" | |||
|
|
|||
| - name: TASTy MiMa | |||
There was a problem hiding this comment.
This takes around 5 minutes (normal MiMa takes 6 minutes). An alternative to this would be to create a new ci job that only executes on nightly or with a flag. Currently, I am the only one doing changes that require these tests and it might not be worth on each PR.
nicolasstucki
force-pushed
the
test-TASTy-MiMa-in-CI
branch
from
fea4f47 to
776cee8
Compare
sjrd
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition does have some fragility with the current TASTy numbering scheme. The test script will change the TASTy version and recompile the compiler and library with this version to allow TASTy MiMa to read those files.
When we change to a new major version, there is the potential for this TASTy to not be readable from the latest release of TASTy MiMa. In that scenario, we would disable this test until a new version of TASTy MiMa is published.
Only test MiMa: [skip community_build] [skip docs] [skip test] [skip test_windows_fast] [skip test_sbt]