Remove OldTastyInspector from scaladoc #17751
Conversation
|
@Florian3k do you know what could be going wrong with that failing test? |
|
From a quick look at this error and source code - I don't have any ideas. |
|
Unfortunately, I wasn't able to figure it out, and I suppose I won't get much further without Windows machine. |
Thank you. We will need the help of someone with a Windows machine. |
sjrd
force-pushed
the
remove-OldTastyInspector
branch
from
c4250f6 to
707d125
Compare
|
Case-insensitive file systems ... 🤦♂️ |
sjrd
force-pushed
the
remove-OldTastyInspector
branch
from
707d125 to
2ae6901
Compare
| @@ -57,7 +57,8 @@ class Scaladoc3ExternalLocationProviderIntegrationTest extends ExternalLocationP | |||
|
|
|||
| def getScalaLibraryPath: String = { | |||
| val classpath: List[String] = System.getProperty("java.class.path").split(java.io.File.pathSeparatorChar).toList | |||
| classpath.find(_.contains("scala-library-2")).getOrElse("foobarbazz") // If we don't find the scala 2 library, the test will fail | |||
| val stdlib = classpath.find(_.contains("scala-library-2")).getOrElse("foobarbazz") // If we don't find the scala 2 library, the test will fail | |||
| new java.io.File(stdlib).getCanonicalPath() // canonicalize for case-insensitive file systems | |||
There was a problem hiding this comment.
@sjrd are these the only changes that you did?
This looks good.
There was a problem hiding this comment.
Yes, that's the only thing I changed.
|
@Florian3k could you double check that the diff of this PR matches the one that you reviewed (modulo the Windows fix)? |
Backports #17751 to the LTS branch. PR submitted by the release tooling. [skip ci]
This a follow-up to #17623 after reverting in #17744.
[test_windows_full]