Remove tpt from Hole
#17455
Merged
Remove tpt from Hole
#17455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
remove-tpt-from-hole
branch
from
87e8a4d to
10bbcd0
Compare
nicolasstucki
commented
May 10, 2023
| @@ -116,8 +116,7 @@ trait QuotesAndSplices { | |||
| } | |||
|
|
|||
| def typedHole(tree: untpd.Hole, pt: Type)(using Context): Tree = | |||
| val tpt = typedType(tree.tpt) | |||
| assignType(tree, tpt) | |||
| assert(false, "Holes should only be typed by the ReTyper") | |||
There was a problem hiding this comment.
Not sure if there is a better pattern for this.
There was a problem hiding this comment.
We throw UnsupportedOperationException in a similar case: https://github.com/lampepfl/dotty/blob/d103f8c97913dbc2eea85b2b2b7b8251c547bdcf/compiler/src/dotty/tools/dotc/typer/Applications.scala#L1470-L1471
nicolasstucki
force-pushed
the
remove-tpt-from-hole
branch
from
10bbcd0 to
082499b
Compare
smarter
approved these changes
May 11, 2023
| @@ -116,8 +116,7 @@ trait QuotesAndSplices { | |||
| } | |||
|
|
|||
| def typedHole(tree: untpd.Hole, pt: Type)(using Context): Tree = | |||
| val tpt = typedType(tree.tpt) | |||
| assignType(tree, tpt) | |||
| assert(false, "Holes should only be typed by the ReTyper") | |||
There was a problem hiding this comment.
We throw UnsupportedOperationException in a similar case: https://github.com/lampepfl/dotty/blob/d103f8c97913dbc2eea85b2b2b7b8251c547bdcf/compiler/src/dotty/tools/dotc/typer/Applications.scala#L1470-L1471
nicolasstucki
force-pushed
the
remove-tpt-from-hole
branch
from
082499b to
711fa7b
Compare
|
Should merge #17424 first and check for conflicts |
Now the type is kept in the `Hole` node.
nicolasstucki
force-pushed
the
remove-tpt-from-hole
branch
from
711fa7b to
2e71268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the type is kept in the
Holenode.