Add unbound placeholder parameter message. #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
suggested changes
Oct 21, 2016
| |Note that this use of `_` is not placeholder syntax, | ||
| |but an uninitialized var definition | ||
| """.stripMargin | ||
| } |
There was a problem hiding this comment.
Great job generalizing this error!
For the explanation I would inline the values codeUnboundInBlock, codeBoundInBlock, codeUnboundVal and codeVar, which would get the error message down from 55 lines to roughly 30.
There was a problem hiding this comment.
Yes that makes sense, the PR has been updated.
rubenpieters
force-pushed
the
issue-1589-unbound-placeholder-parameter-error-message
branch
from
54a1ced to
726b129
Compare
felixmulder
approved these changes
Oct 21, 2016
|
Looks good @rubenpieters - could you bump the |
rubenpieters
force-pushed
the
issue-1589-unbound-placeholder-parameter-error-message
branch
from
726b129 to
273df6b
Compare
|
Ok done. |
|
@rubenpieters - unfortunately merging the other PR caused this to become a merge conflict. So it needs to be rebased. Sorry about that :( |
rubenpieters
force-pushed
the
issue-1589-unbound-placeholder-parameter-error-message
branch
from
273df6b to
bf80147
Compare
|
No problem, the conflicts have been resolved. |
|
Merged! Thanks for your patience 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1589
Addition of message for the 'unbound placeholder parameter' error message (Parsers.scala 337).
I tried to check what is available in the vd ValDef in checkNoEscapingPlaceholders (Parsers.scala 330), but I couldn't really find anything which could be used to enhance the error message.