Fix compiler crash in sealedStrictDescendants
#15919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Aug 26, 2022
| @@ -1626,7 +1626,7 @@ object SymDenotations { | |||
| // is defined in the same scope as `cls` or in the companion object of `cls`. | |||
| completeChildrenIn(owner) | |||
| completeChildrenIn(companionClass) | |||
| setFlag(ChildrenQueried) | |||
| if isType then setFlag(ChildrenQueried) | |||
There was a problem hiding this comment.
I think it'd be better to skip the whole thing if the symbol is a type, otherwise it will recompute every time
There was a problem hiding this comment.
I'm not sure what you mean, could you elaborate?
There was a problem hiding this comment.
So I've come across this again, the problem is calling children recursively in sealedStrictDescendants, and the isAllOf(JavaEnumTrait) will also return true for java enum cases, so best to check that it is also a class
|
Maybe instead of conditionally setting the flag, could you try setting |
|
thanks for opening this originally! closing in favour of #19074 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15908