[bp] bump compiler-interface and capture the diagnosticCode #15794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: It's important that in `Problem` we don't construct the actual `DiagnosticCode` _unless_ the method is called to get it. By doing this we keep compatibility ensuring that older build tools can still use the bridge just fine. That's what the `sbt-test/sbt-bridge` tests ensuring that this is still usable by an older tool using the old `Problem`. This then unlocks forwarding the diagnostic code on for tools to use. refs: scala#14904
|
Btw in order for the tests to pass for this #15728 would also need to be backported because the test that I added to needs 1.7.x since we're actually checking that the diagnostic code is there. The compat tests should still be fine, just not the one that checks the code. |
* dep: update fs2 submodule This is needed due to some scalablytyped stuff that changed in fs2. Without it, you'll get an error when updating the sbt 1.7.x that scalably typed doesn't support 1.7.x * dep: sync with latest staging http4s * dep: sync with latest scala-java8-compat This also allows us to get rid of the fnGen stuff and simplify the sbtTestCommand and sbtPublishCommand * dep: sync with latest cats in staging * dep: sync with latest munit-cats-effect * dep: sync with latest discipline and discipline-munit * dep: lock munit at 0.7.29 If not you'll have issues with http4s tests since http4s isn't using the 1.x version of munit yet * disable `tlFatalWarnings` in http4s * dep: lock scalacheck at 1.16.0 Without doing this it was getting stuck in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #15565
NOTE: It's important that in
Problemwe don't construct the actualDiagnosticCodeunless the method is called to get it. By doing this wekeep compatibility ensuring that older build tools can still use the
bridge just fine. That's what the
sbt-test/sbt-bridgetests ensuringthat this is still usable by an older tool using the old
Problem. Thisthen unlocks forwarding the diagnostic code on for tools to use.
refs: #14904