Post-process STRINGPART #15519
Closed
Post-process STRINGPART #15519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting the next part of an interpolation, consisting of the literal part followed by the interpolated identifier or expression, defer fetching the identifier to postProcessToken. This ensures that lookahead at an interpolation looks ahead only one token.
If there is already a next token, don't overwrite it. Give a pass to lookahead scanner as a hedge, assuming lookahead results are merely a probe and are discarded, and may be looking at erroneous input.
|
Added the assert on reset from the sibling PR. |
som-snytt
commented
Jun 24, 2022
| @@ -751,6 +751,8 @@ object Scanners { | |||
| closeIndented() | |||
| case EOF => | |||
| if !source.maybeIncomplete then closeIndented() | |||
| case STRINGPART => | |||
| finishStringPart() | |||
There was a problem hiding this comment.
A Finnish string part would be the violins in Sibelius's Finlandia.
odersky
requested changes
Jun 25, 2022
There was a problem hiding this comment.
I must admit I found this hard to follow, and a bit unsystematic, since postProcess usually does not fiddle with token details like that.
I believe it's best to simply forbid looking ahead beyond an INTERPOLATIONID. It turned out forbidding this revealed a bug in Parser where the real problem lied.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the next part of an interpolation,
consisting of the literal part followed by the interpolated
identifier or expression, defer fetching the identifier
to postProcessToken. This ensures that lookahead at an
interpolation looks ahead only one token.
Fixes #15514