Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DecompilerPrinter.scala #15445

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Remove DecompilerPrinter.scala #15445

merged 1 commit into from
Jun 23, 2022

Conversation

EstebanMarin
Copy link
Contributor

@EstebanMarin EstebanMarin commented Jun 14, 2022

Description: We tested all methods in REPL and none of them the methods being used.
All tests pass. do while loop are not supported anymore. packages are not printed in REPL
nor content of classes either.

fixes #14806

@nicolasstucki nicolasstucki self-assigned this Jun 14, 2022
@nicolasstucki nicolasstucki self-requested a review June 14, 2022 16:34
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@nicolasstucki
Copy link
Contributor

To fix the MiMa tests, we should be able to re-run the tests after #15457 is merged (no-rebase needed).

@nicolasstucki
Copy link
Contributor

@EstebanMarin could you squash the commits?

Description: We tested all methods in REPL and none of them are used
all test passes. Do while do not exist anymore, `packages`
are printed, not content of classes either.

fixes scala#14806
@EstebanMarin
Copy link
Contributor Author

@nicolasstucki done

@nicolasstucki nicolasstucki enabled auto-merge June 16, 2022 14:03
@nicolasstucki nicolasstucki merged commit f92ab11 into scala:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old DecompilerPrinter
2 participants