Don't trust @unchecked types when optimizing type tests #14709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some type tests are elided or replaced with non null-checks if we can show that the expression's type is a subtype of the test type. But that can be done safely only if the expression's type does not come from an `@unchecked` cast, inserted by pattern matching or the user. Fixes scala#14705
som-snytt
reviewed
Mar 18, 2022
|
Closed in favor of #14715 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some type tests are elided or replaced with non null-checks if we can show
that the expression's type is a subtype of the test type. But that can be done
safely only if the expression's type does not come from an
@uncheckedcast,inserted by pattern matching or the user.
Fixes #14705