Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable type simplify in unpickler #14506

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Disable type simplify in unpickler #14506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b64f282
Disable type simplify in unpickler
noti0na1 Feb 17, 2022
8f50785
Rename test file
noti0na1 Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions compiler/src/dotty/tools/dotc/core/tasty/TreeUnpickler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,8 +1297,6 @@ class TreeUnpickler(reader: TastyReader,
}

val tree = if (tag < firstLengthTreeTag) readSimpleTerm() else readLengthTerm()
if (!tree.isInstanceOf[TypTree]) // FIXME: Necessary to avoid self-type cyclic reference in tasty_tools
tree.overwriteType(tree.tpe.simplified)
setSpan(start, tree)
}

Expand Down
15 changes: 15 additions & 0 deletions tests/pos/pickleSkolem.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
class A

type B = A

def f[T](x: T): x.type & T = ???

def g = {
var a: B = ???
f[A](a)
}

def testNN = {
var s: String = ???
s.nn
}