Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate unreported features when flushing a reporter #14503

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Propagate unreported features when flushing a reporter #14503

merged 2 commits into from
Feb 17, 2022

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Feb 16, 2022

Fixes #14500

@odersky
Copy link
Contributor Author

odersky commented Feb 16, 2022

Not sure how to do a test. We are after the one line of the summary, no other errors should be reported. So we can't turn -feature on.

@odersky odersky requested a review from dwijnand February 17, 2022 11:02
dwijnand
dwijnand approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That message is emitted as an info message and our testing sets up to only looks for error messages. But I'm happy to land this as it is.

@dwijnand dwijnand merged commit d09dd2a into scala:main Feb 17, 2022
@dwijnand dwijnand deleted the track-nested-unreported branch February 17, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@som-snytt som-snytt som-snytt left review comments

@dwijnand dwijnand dwijnand approved these changes

Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature warnings don't show
3 participants
@odersky @dwijnand @som-snytt