Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary type from UnApply #13302

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Remove unnecessary type from UnApply #13302

merged 1 commit into from
Aug 27, 2021

Conversation

nicolasstucki
Copy link
Contributor

This type is never used, it is just a placeholder to make the tree typed.
It is the Typed tree around the UnApply that holds the type information.

@nicolasstucki nicolasstucki force-pushed the remove-proto-from-typed-unapply branch from e4d5057 to 168b7c8 Compare August 16, 2021 15:36
@nicolasstucki nicolasstucki mentioned this pull request Aug 17, 2021
Merged
@nicolasstucki nicolasstucki self-assigned this Aug 18, 2021
@nicolasstucki nicolasstucki requested a review from smarter August 20, 2021 11:44
@nicolasstucki nicolasstucki marked this pull request as ready for review August 20, 2021 11:45
@smarter smarter assigned nicolasstucki and unassigned smarter Aug 23, 2021
@nicolasstucki nicolasstucki requested a review from dwijnand August 24, 2021 06:27
@nicolasstucki nicolasstucki added this to the 3.1.0 milestone Aug 26, 2021
dwijnand
dwijnand reviewed Aug 26, 2021
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things, but feel free to merge it when you want, to make sure it's in 3.1.0.

compiler/src/dotty/tools/dotc/typer/QuotesAndSplices.scala Outdated Show resolved Hide resolved
compiler/src/dotty/tools/dotc/typer/QuotesAndSplices.scala Outdated Show resolved Hide resolved
compiler/src/dotty/tools/dotc/core/tasty/TreeUnpickler.scala Show resolved Hide resolved
@nicolasstucki @dwijnand
Remove unnecessary type from UnApply
aeb3db1 
This type is never used, it is just a placeholder to make the tree typed.
It is the `Typed` tree around the `UnApply` that holds the type information.

Co-authored-by: Dale Wijnand <[email protected]>
@nicolasstucki nicolasstucki force-pushed the remove-proto-from-typed-unapply branch from 54ce03b to aeb3db1 Compare August 26, 2021 12:28
@nicolasstucki nicolasstucki requested a review from dwijnand August 26, 2021 14:25
@dwijnand dwijnand merged commit 094a3c5 into scala:master Aug 27, 2021
@dwijnand dwijnand deleted the remove-proto-from-typed-unapply branch August 27, 2021 08:50
@SethTisue SethTisue mentioned this pull request Feb 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@smarter smarter Awaiting requested review from smarter

Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @smarter @dwijnand