Decouple -print-tasty from compiler #13276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This improvement was necessary to debug #13234 |
nicolasstucki
force-pushed
the
standalone-tasty-printer
branch
from
6e32ac5 to
90b7514
Compare
To print the contents of a tasty file we only need the bytes of the file. The current architecture forced us to load the context and have a wroking classpath. When debugging, we sometimes need to see the contents of a tasty file witouth having the full classpath available. * Use `dotty.tools.dotc.core.TastyPrinter.main` as new entry point * Decouple `-decompile` from `-print-tasty` * Only require .tasty file to be able to print its contents * Keep the same CLI commands and flags
nicolasstucki
force-pushed
the
standalone-tasty-printer
branch
from
058e734 to
daab244
Compare
dwijnand
reviewed
Aug 12, 2021
dwijnand
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To print the contents of a tasty file we only need the bytes of the file.
The current architecture forced us to load the context and have a wroking classpath.
When debugging, we sometimes need to see the contents of a tasty file witouth having the full classpath available.
dotty.tools.dotc.core.TastyPrinter.mainas new entry point-decompilefrom-print-tasty