Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "sbt 1.5.5 (was 1.5.3)" #13180

Closed

Conversation

nicolasstucki
Copy link
Contributor

This reverts commit de79e58.

@nicolasstucki
Copy link
Contributor Author

This change seems to have started failures in stdlib-sourcelinks-test for all PRs.

See https://github.com/lampepfl/dotty/pull/13179/checks?check_run_id=3180394280

@nicolasstucki nicolasstucki requested a review from romanowski July 28, 2021 11:12
@nicolasstucki nicolasstucki marked this pull request as ready for review July 28, 2021 11:12
@BarkingBad
Copy link
Contributor

As I said, it depends on some external causes, for example running sbt scaladoc/sourceLinksIntegrationTest:test from the newest master (pulled a few minutes ago) locally succeeds with no error, whereas on GitHub it failed. Can you try running this yourself? Maybe you'd encounter the same "problem"

@griggt
Copy link
Contributor

griggt commented Jul 28, 2021

running sbt scaladoc/sourceLinksIntegrationTest:test from the newest master (pulled a few minutes ago) locally succeeds with no error, whereas on GitHub it failed.

The members that are tested are selected at random, and the random number generator on CI seems to produce a different sequence for the same seed than is produced locally. For me locally, IntegralProxy is selected from ScalaNumberProxy.scala, whereas on CI, ScalaWholeNumberProxy is selected.

Neither of these seems to be correctly linked in the current API docs.
IntegralProxy links to L60 when I think it should link to L55.
ScalaWholeNumberProxy links to L57 instead of L52.

Also, there is a bug in the test which is causing it to be more lenient than it should be:

https://github.com/lampepfl/dotty/blob/d7d70c06ecdc0d5c5a40fab75beaf265992a865b/scaladoc/test-source-links/dotty/tools/scaladoc/source-links/RemoteLinksTest.scala#L46-L48

Here, expectedLine is of type String

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants