Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Dotty Reference to 3.0.0 #12464

Merged
merged 1 commit into from
May 18, 2021

Conversation

anatoliykmetyuk
Copy link
Contributor

No description provided.

@smarter
Copy link
Member

smarter commented May 14, 2021

fs2 fails (I don't see how this could be related to this change so it's likely flakey?) /cc @mpilquist:

[error] ==> X fs2.StreamCombinatorsSuite.groupWithin - accumulation and splitting  0.481s munit.ComparisonFailException: /__w/dotty/dotty/community-build/community-projects/fs2/core/shared/src/test/scala/fs2/StreamCombinatorsSuite.scala:851
[error] 850:        .toList
[error] 851:        .assertEquals(expected)
[error] 852:    }
[error] values are not the same
[error] => Obtained
[error] List(
[error]   List(
[error]     1,
[error]     2,
[error]     3
[error]   ),
[error]   List(
[error]     4
[error]   ),
[error]   List(
[error]     5,
[error]     6,
[error]     7,
[error]     8,
[error]     9
[error]   ),
[error]   List(
[error]     10,
[error]     11,
[error]     12,
[error]     13,
[error]     14
[error]   ),
[error]   List(
[error]     15,
[error]     16,
[error]     17,
[error]     18,
[error]     19
[error]   ),
[error]   List(
[error]     20,
[error]     21,
[error]     22
[error]   )
[error] )
[error] => Diff (- obtained, + expected)
[error]    List(
[error] -    4
[error] -  ),
[error] -  List(
[error] +    4,
[error]      5,
[error]      7,
[error] -    8,
[error] -    9
[error] +    8
[error]    ),
[error]    List(
[error] +    9,
[error]      10,
[error]      12,
[error] -    13,
[error] -    14
[error] +    13
[error]    ),
[error]    List(
[error] +    14,
[error]      15,
[error]      17,
[error] -    18,
[error] -    19
[error] +    18
[error]    ),
[error]    List(
[error] +    19,
[error]      20,
[error]     at munit.FunSuite.assertEquals(FunSuite.scala:11)
[error]     at munit.CatsEffectAssertions.assertIO$$anonfun$2$$anonfun$1(CatsEffectAssertions.scala:49)
[error]     at cats.effect.IO$.apply$$anonfun$1(IO.scala:806)
[error]     at cats.effect.IOFiber.runLoop(IOFiber.scala:270)
[error]     at cats.effect.IOFiber.asyncContinueSuccessfulR(IOFiber.scala:1132)
[error]     at cats.effect.IOFiber.run(IOFiber.scala:126)
[error]     at cats.effect.unsafe.WorkerThread.run(WorkerThread.scala:384)
[error] Failed: Total 1447, Failed 1, Errors 0, Passed 1428, Skipped 18
[error] Failed tests:
[error] 	fs2.StreamCombinatorsSuite

@mpilquist
Copy link
Contributor

mpilquist commented May 14, 2021 via email

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that #12371 is merged, we should at the same time as we bump the referenceVersion bump the previousDottyVersion

@anatoliykmetyuk
Copy link
Contributor Author

Rebased on master.

Currently previousDottyVersion and previousDottyBinaryVersion are already set to 3.0.0-RC3 – is that not correct?

@smarter
Copy link
Member

smarter commented May 17, 2021

It should be set to the latest published version (and the whitelist in project/MiMaFilters.scala should be cleared every time it's updated), so it should be 3.0.0 (which is identical to 3.0.0-RC3 so we won't clear the whitelist this time)

project/Build.scala Outdated Show resolved Hide resolved
@anatoliykmetyuk anatoliykmetyuk requested a review from smarter May 18, 2021 09:06
@smarter smarter merged commit 4bf2f04 into scala:master May 18, 2021
@smarter smarter deleted the scala3-release-3.0.0 branch May 18, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants